Fix 2.4 sync #1585
Merged
Fix 2.4 sync #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev -> Master for v2.4 release
This comment was marked as resolved.
This comment was marked as resolved.
drpatelh
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear whether this PR changes anything important - main thing is that I switched the order of
self.gh_api.lazy_init()so that auth is set after that. But I don't think that it should make any difference really. The rest of it is mostly additional logging.Managed to almost replicate the sync error locally (got 401 errors instead of 404). Renewed the bot token and then it worked locally. Not sure what else I can do really 🤔
PR checklist
CHANGELOG.mdis updateddocsis updated